Skip to content

Unquote type annotations in create_secrets_files #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Apr 25, 2026
Merged

Unquote type annotations in create_secrets_files #3126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions admin/create_secrets_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,24 @@
import sys
import textwrap
from pathlib import Path
from typing import TYPE_CHECKING

import vws_web_tools
from selenium.common.exceptions import TimeoutException

if TYPE_CHECKING:
from selenium.webdriver.remote.webdriver import WebDriver
from vws_web_tools import DatabaseDict, VuMarkDatabaseDict

from selenium.webdriver.remote.webdriver import WebDriver
from vws_web_tools import DatabaseDict, VuMarkDatabaseDict

VUMARK_TEMPLATE_SVG_FILE_PATH = Path(__file__).with_name(
name="vumark_template.svg",
)


def _create_and_get_cloud_database_details(
driver: "WebDriver",
driver: WebDriver,
email_address: str,
password: str,
cloud_license_name: str,
cloud_database_name: str,
) -> "DatabaseDict":
) -> DatabaseDict:
"""Create a cloud database and get its details.

Returns database details.
Expand Down Expand Up @@ -57,9 +53,9 @@ def _create_and_get_cloud_database_details(


def _create_and_get_vumark_details(
driver: "WebDriver",
driver: WebDriver,
vumark_database_name: str,
) -> "VuMarkDatabaseDict":
) -> VuMarkDatabaseDict:
"""Create a VuMark database and get its details.

Returns VuMark database details.
Expand All @@ -76,10 +72,10 @@ def _create_and_get_vumark_details(


def _generate_secrets_file_content(
cloud_database_details: "DatabaseDict",
vumark_details: "VuMarkDatabaseDict",
inactive_database_details: "DatabaseDict",
inactive_vumark_details: "VuMarkDatabaseDict",
cloud_database_details: DatabaseDict,
vumark_details: VuMarkDatabaseDict,
inactive_database_details: DatabaseDict,
inactive_vumark_details: VuMarkDatabaseDict,
vumark_target_id: str,
) -> str:
"""Generate the content of a secrets file."""
Expand Down Expand Up @@ -110,7 +106,7 @@ def _generate_secrets_file_content(


def _create_and_get_vumark_target_id(
driver: "WebDriver",
driver: WebDriver,
vumark_database_name: str,
vumark_template_name: str,
) -> str:
Expand All @@ -130,12 +126,12 @@ def _create_and_get_vumark_target_id(


def _create_and_get_inactive_database_details(
driver: "WebDriver",
driver: WebDriver,
email_address: str,
password: str,
cloud_license_name: str,
cloud_database_name: str,
) -> "DatabaseDict":
) -> DatabaseDict:
"""Create a cloud database, get its details, then delete the license to
make it inactive.
"""
Expand Down Expand Up @@ -164,12 +160,12 @@ def _create_and_get_inactive_database_details(


def _create_and_get_inactive_vumark_details(
driver: "WebDriver",
driver: WebDriver,
email_address: str,
password: str,
vumark_license_name: str,
vumark_database_name: str,
) -> "VuMarkDatabaseDict":
) -> VuMarkDatabaseDict:
"""Create a VuMark database, get its details, then delete the license
to
make it inactive.
Expand Down
Loading