Unquote type annotations in create_secrets_files#3126
Merged
adamtheturtle merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
WebDriver,DatabaseDict, andVuMarkDatabaseDictimports out of theTYPE_CHECKINGblock so the annotations inadmin/create_secrets_files.pyno longer need to be string-quoted.🤖 Generated with Claude Code
Note
Low Risk
Low risk: this is a typing-only refactor that changes imports and annotations without altering runtime behavior or test data flow.
Overview
Removes the
TYPE_CHECKING-guarded imports inadmin/create_secrets_files.pyand importsWebDriver,DatabaseDict, andVuMarkDatabaseDictat runtime.Updates function signatures to use direct type annotations (no string quotes) for driver parameters and database-detail return/argument types.
Reviewed by Cursor Bugbot for commit fb6f286. Bugbot is set up for automated code reviews on this repo. Configure here.