Skip to content

Unquote type annotations in create_secrets_files#3126

Merged
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/unquote-types
Apr 25, 2026
Merged

Unquote type annotations in create_secrets_files#3126
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/unquote-types

Conversation

@adamtheturtle
Copy link
Copy Markdown
Member

@adamtheturtle adamtheturtle commented Apr 25, 2026

Move the WebDriver, DatabaseDict, and VuMarkDatabaseDict imports out of the TYPE_CHECKING block so the annotations in admin/create_secrets_files.py no longer need to be string-quoted.

🤖 Generated with Claude Code


Note

Low Risk
Low risk: this is a typing-only refactor that changes imports and annotations without altering runtime behavior or test data flow.

Overview
Removes the TYPE_CHECKING-guarded imports in admin/create_secrets_files.py and imports WebDriver, DatabaseDict, and VuMarkDatabaseDict at runtime.

Updates function signatures to use direct type annotations (no string quotes) for driver parameters and database-detail return/argument types.

Reviewed by Cursor Bugbot for commit fb6f286. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@adamtheturtle adamtheturtle merged commit 5c71072 into main Apr 25, 2026
11 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/unquote-types branch April 25, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant