Skip to content

fix(dash-tui): stop the Engines preview claiming "Lemonade — not installed" #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lide4144 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −16
Open

fix(dash-tui): stop the Engines preview claiming "Lemonade — not installed" #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions crates/rocm-dash-tui/src/ui/tabs/pane.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,23 +361,19 @@ fn live_lines(action: KeyAction, state: &AppState, theme: &Theme) -> Vec<Line<'s
}
KeyAction::OpenEngineManager => {
let mut lines = vec![head("Engines".into())];
let lemon = info().and_then(|i| i.lemond_version.clone());
lines.push(Line::from(vec![
mark(lemon.is_some()),
Span::styled(
lemon.map_or_else(
|| "Lemonade — not installed".into(),
|v| format!("Lemonade {v}"),
),
Style::default().fg(theme.fg),
),
]));
// The daemon doesn't surface vLLM detection yet — open the manager to
// The daemon doesn't surface engine detection yet — `GpuSystemInfo`
// has no producer for `lemond_version`, so every value read here
// would be `None` no matter what is installed. Open the manager to
// check rather than claiming a status we don't have.
lines.push(Line::from(vec![
Span::styled("· ", Style::default().fg(theme.muted)),
Span::styled("vLLM — open to check", Style::default().fg(theme.muted)),
]));
for engine in ["Lemonade", "vLLM"] {
lines.push(Line::from(vec![
Span::styled("· ", Style::default().fg(theme.muted)),
Span::styled(
format!("{engine} — open to check"),
Style::default().fg(theme.muted),
),
]));
}
lines
}
KeyAction::OpenServeWizard => {
Expand Down