fix(dash-tui): stop the Engines preview claiming "Lemonade — not installed" - #367
Open
lide4144 wants to merge 1 commit into
Open
fix(dash-tui): stop the Engines preview claiming "Lemonade — not installed"#367lide4144 wants to merge 1 commit into
lide4144 wants to merge 1 commit into
Conversation
…alled"
The preview read GpuSystemInfo::lemond_version, a field nothing in the codebase ever
writes (declaration + demo stub + this one reader), so the Option was always None,
mark() always drew the off-glyph, and the `Lemonade {v}` arm was unreachable. The
panel asserted a negative it had no data for and pushed users into a no-op
`rocm engines install lemonade`, while `rocm engines list` correctly reported the
engine as ready.
Render Lemonade the way the adjacent vLLM line already did - muted "open to check" -
since that branch was already honest about having no engine detection. vLLM
rendering is unchanged. Populating lemond_version in the collector is the real
follow-up; it would make the dash collector learn about engine manifests, so it is
left out here.
Fixes ROCm#366
Signed-off-by: lide4144 <170252421+lide4144@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #366
The dashboard's Serving → Engines preview always rendered
· Lemonade — not installed, on machines where Lemonade is installed androcm engines listcorrectly reportsnote: Lemonade is ready on your AMD GPU.crates/rocm-dash-tui/src/ui/tabs/pane.rsreadGpuSystemInfo::lemond_version, but nothing in the codebase ever writes that field:rocm-dash-collectors::AmdSmiCollector::system_info()→parse_system_info()buildsGpuSystemInfo::default()and fills onlyrocm_version,driver_version, model, counts, partition modes and VRAM. Solemon.is_some()was statically false,mark(...)always drew the "off" glyph, and theformat!("Lemonade {v}")arm was unreachable — the panel asserted a negative it had no data for, and pushed users into a no-oprocm engines install lemonade.Change
Drops the false claim and renders Lemonade the way the adjacent vLLM line already does — "open to check", muted — since that branch was already honest about having no detection. Both engine lines now come from one loop.
Before / after in the preview panel:
vLLM's rendering is byte-identical.
mark()andinfo()stay in use by the ROCm/driver lines in the same function, so no other call sites changed.Deliberately minimal: this stops the wrong statement without inventing a detection path. The real fix is to populate
lemond_versionin the collector (reusing the resolutionrocm engines listalready performs inengines/lemonade/src/lib.rs) so the panel can showLemonade 11.5.1— happy to do that as a follow-up if maintainers prefer it over the honest placeholder, but it means the dash collector learns about engine manifests, which felt like the wrong direction for a drive-by.Left in place: the sibling fields
llama_server_build,ccr_version,llamacpp_backend(metrics.rs:60-62) have the same declared-never-written shape. They're currently unread, so no other UI lies today; removing or wiring them up is a separate call.Verification
rustfmt --edition 2024 --check crates/rocm-dash-tui/src/ui/tabs/pane.rs→ cleancargo check -p rocm-dash-tui --all-targets→ finished, no warningsgrep -rn "not installed\|open to check\|lemond_version" crates/rocm-dash-tuimatched only the lines changed here);pane.rshas nomod tests, so nothing to updateNo test added:
pane.rshas no test module, so asserting onlive_lines()means building anAppState+Snapshotfixture from scratch in a file that deliberately has none — heavier than the 4-line change it would guard. Happy to add one if a maintainer wants it, ideally alongside whoever wireslemond_versionup for real.Note: this commit was authored through the GitHub
createCommitOnBranchAPI (the same path.github/workflows/dependabot-manifests-commit.ymluses), so it is web-flow signed (verification.verified = true) and carries aSigned-off-bytrailer —cargo xtask verify-commits --require-verifiedshould pass. The author has no local signing key and the API token cannot register one.