fix: handle NHWC image format in wandb logging for train_pytorch.py#930
Open
enjoysport2022 wants to merge 1 commit intoPhysical-Intelligence:mainfrom
Open
fix: handle NHWC image format in wandb logging for train_pytorch.py#930enjoysport2022 wants to merge 1 commit intoPhysical-Intelligence:mainfrom
enjoysport2022 wants to merge 1 commit intoPhysical-Intelligence:mainfrom
Conversation
The unified dataloader returns images in NHWC format [B, H, W, C], but the wandb logging code assumed NCHW format and incorrectly applied permute(1,2,0), resulting in "Un-supported shape [224, 9, 224]" error. Changes: - Detect image format by checking if first dim is 3 (NCHW) or not (NHWC) - Only permute when image is actually in NCHW format - Rescale pixel values from [-1, 1] to [0, 1] range for wandb compatibility - Clip values to [0, 1] to avoid wandb warnings Fixes Physical-Intelligence#877 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The unified dataloader returns images in NHWC format
[B, H, W, C](consistent with JAX/LeRobot), but the wandb logging code assumed NCHW format and incorrectly appliedpermute(1, 2, 0), resulting in shape[W, C, H]which wandb cannot recognize.Test Plan
Fixes #877