Repository navigation
Clear the Dependabot alerts - #3020
Merged
Merged
Conversation
- drop the npm copies of @openzeppelin/contracts and @chainlink/contracts-ccip: nothing in JS imports them and Foundry compiles against the soldeer copies in dependencies/ - bump axios 1.4.0 -> 1.20.0 (only used by tasks/merkl.js) - add pnpm overrides that lift each vulnerable transitive range to its first patched release in the same major (elliptic, ws, bn.js, js-yaml, qs, fast-xml-builder, and dev tooling)
shahthepro
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot alerts were just enabled on this repo, and the scan found 128 open alerts. This PR fixes 127 of them without touching any contract source. The remaining one has no fix published upstream.
The Talos actions image runs
pnpm install --frozen-lockfilewithout--prod, so dev dependencies ship in the image too. That is why the runtime and dev-tooling fixes go in together.axios1.4.0 (only used bytasks/merkl.js)form-dataandfollow-redirects.@openzeppelin/contracts4.4.2 and@chainlink/contracts-ccip1.2.1 (which pulled OZ 3.4.2 / 4.3.3, OZ upgradeable 4.7.3 and@eth-optimism/*)dependencies/(seeremappingsandlibsinfoundry.toml). Our contracts don't import any of the affected OZ modules (ECDSA, Governor, SignatureChecker, ERC165Checker, MerkleProof, Base64, TransparentUpgradeableProxy).elliptic(the critical one, used by ethers v5 signing),ws,bn.js,js-yaml,qs,fast-xml-builderpnpm-workspace.yaml.fast-uri,brace-expansion,minimatch,serialize-javascript,lodash,nanoid,picomatch,flatted, plusajv,diffandpbkdf2flagged bypnpm auditHow the overrides work:
wsis overridden by parent package. A barews@<range>selector also rewroteisows'ws: "*"peer range and caused an unmet-peer warning.serialize-javascriptis the one major bump (6 → 7, for mocha only). Its RCE fix was never backported to 6.x; 7.x keeps the same API and needs Node ≥ 20.minimumReleaseAge.Left open (no upstream fix):
ellipticGHSA-848j-6mx2-7j84 (low, "risky primitive", affects all versions ≤ 6.6.1). Alert Remove IViewVault and IViewMinMaxOracle interfaces #402 can be dismissed as "no fix available".braces≤ 3.0.3 is reported bypnpm auditonly, and no patched release exists.Result
pnpm audit: 135 advisories → 2. These are the two with no upstream fix above.Testing
pnpm install --frozen-lockfilepasses.make build-contractsandmake build-scriptspass.pnpm test:tasks(75),pnpm test:scriptsandpnpm test:layoutspass.pnpm lint(eslint + solhint),pnpm typecheckand prettier pass.elliptic6.6.1: signing and recovering a type-2 transaction, a personal message and EIP-712 typed data all work.axios1.20.0: the realtasks/merkl.jsrequest (api.merkl.xyz/v4/users/…/rewards) returns 200.@aws-sdk/client-kms,@lodestar/configand the@safe-globalkits all load.Follow-ups
--prodand move what it needs intodependencies. That would take the dev tooling out of the signing container altogether.🤖 Generated with Claude Code