Repository navigation
Clear the Dependabot alerts - #361
Merged
Merged
Conversation
- bump axios ^1.9.0 -> ^1.20.0 - add pnpm overrides that lift each vulnerable transitive range to its first patched release: ws (scoped by parent), undici 5 -> 6 under Hardhat, immutable, js-yaml, fast-xml-builder, follow-redirects, adm-zip, tmp, cookie, pbkdf2, brace-expansion, serialize-javascript
shahthepro
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 59 of the 61 open Dependabot alerts on arm-oeth, with no contract or task code changes. This is the same approach as OriginProtocol/origin-dollar#3020.
All 61 alerts are on dev dependencies. However, the Talos actions image runs
pnpm install --frozen-lockfilewithout--prod, so they all ship in the container that signs ARM transactions. Most of them come from Hardhat 2, which runs every ARM action. The latest 2.x release (2.29.1) still pins the same old transitive versions, so bumping Hardhat does not help.axios1.14.0form-data)^1.20.0undici5.29.0 (+@fastify/busboy2.1.1)hardhathardhat>undici→^6.28.1. All fixes exist only in 6.x. See below.adm-zip0.4.16hardhat^0.6.1immutable4.3.8hardhat^4.3.9ws7.5.10 / 8.17.1 / 8.18.0hardhat,ethers,@ethersproject/providers^7.5.11/^8.21.0, scoped by parenttmp0.0.33solc^0.2.6cookie0.4.2@sentry/node(Hardhat telemetry)^0.7.0js-yaml,fast-xml-builder,follow-redirects,brace-expansion,serialize-javascriptserialize-javascript6 → 7 for mochapbkdf2(fromethereum-cryptography) is also lifted to 3.1.7. Onlypnpm auditflags it.The one change to watch:
undici6 under Hardhat 2. undici is Hardhat 2's HTTP client, so it carries every RPC call of every ARM action. The 9 undici advisories (request smuggling, CRLF and header injection, response splitting) are only fixed in 6.x. I checked:hardhat snap --arm WETH), which reads ARM state and calls the Kyber API;hardhat collectFees --arm Lido, impersonated): the transaction was sent, mined and logged;hardhat compile --force.If you'd rather keep undici 5, drop the single
hardhat>undiciline. That leaves 10 alerts open.Left open (2):
uuid8.3.2 (medium). The bug is in v3/v5/v6 with a caller-supplied buffer; Hardhat only uses v4. The fix is in 11.x. Dismiss as "vulnerable code not used".elliptic6.6.1 (low, GHSA-848j-6mx2-7j84). No patched release exists. Dismiss as "no fix available".Result
pnpm audit: 3 left (uuidandellipticabove, plusbraces≤ 3.0.3, which has no patched release).minimumReleaseAge.Testing
pnpm install --frozen-lockfileandpnpm lintpass.hardhat compile --force,hardhat snap --network mainnet --arm WETHandhardhat collectFees --network local --arm Lido(anvil fork) all pass.NODE_PATH=node_modules/.pnpm/node_modules node dump-actions-catalog.cjs, as indockerfile-actions) produces 151 entries.pnpm prettier:check(src/abis/OriginARMV1.json) andpnpm typecheck(missing@types/node) fail the same way onmain. This PR doesn't change either.🤖 Generated with Claude Code