Return correct buffer size after compression in blosc2 and lz4#247
Merged
ajelenak merged 7 commits intoHDFGroup:masterfrom May 6, 2026
Merged
Return correct buffer size after compression in blosc2 and lz4#247ajelenak merged 7 commits intoHDFGroup:masterfrom
ajelenak merged 7 commits intoHDFGroup:masterfrom
Conversation
fortnern
requested review from
ajelenak,
bmribler,
brtnfld,
glennsong09,
jhendersonHDF,
lrknox and
mattjala
as code owners
fortnern
changed the title
Contributor
|
Have you seen my PR #246? I am ok if you want to take over in this one, but the LZ4 plugin also needs a fix. |
Member
Author
Sorry I didn't see that. I think this fix is better. I was only looking at blosc2 but I'll integrate the lz4 fix from 246 |
fortnern
changed the title
avoid violating assumptions about the meaning of that variable elsewhere in the code.
jhendersonHDF
approved these changes
May 6, 2026
lrknox
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters need to return the correct buffer size to avoid memory errors. This is now enforced in HDF5 develop, though not doing so could be a problem for any version of HDF5. I haven't tested this yet since, hopefully there are automated checks.