Fix filter callback buffer size for LZ4 read and BLOSC2 compress#246
Open
Fix filter callback buffer size for LZ4 read and BLOSC2 compress#246
Conversation
HDF5 PR #6184 added a stricter check that filters report *buf_size >= return value after running. The LZ4 decompression path failed to update *buf_size after reallocating, and the BLOSC2 compression path left it at the precomputed uncompressed-chunk size, which can be smaller than the compressed output for small or incompressible chunks.
ajelenak
requested review from
bmribler,
brtnfld,
fortnern,
glennsong09,
jhendersonHDF,
lrknox and
mattjala
as code owners
Contributor
|
Do you plan to open follow-up issues/PRs for BLOSC, BZIP2, and LZF on their end? It does not do much good to fix it here. Bzip2 and LZF also have an issue. |
Contributor
Author
|
@brtnfld My recommendation is to proceed with the current set up for now, and also start evaluating how to transition to third-party plugin repositories that appear well maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDF5 PR HDFGroup/hdf5#6184 added a stricter check that filters report
*buf_size>= return value after running. The LZ4 plugin decompression path failed to update*buf_sizeafter reallocating, and the BLOSC2 plugin compression path left it at the precomputed uncompressed-chunk size, which can be smaller than the compressed output for small or incompressible chunks.