Skip to content

Fix ValidateCounterId so an ID exactly equal to MaxCounterId also fails #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
strangelydim wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix ValidateCounterId so an ID exactly equal to MaxCounterId also fails #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Adaptive.Agrona/Concurrent/Status/CountersReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,12 @@ public string GetCounterLabel(int counterId)

private void ValidateCounterId(int counterId)
{
if (counterId < 0 || counterId > MaxCounterId)
// .NET's MaxCounterId is one-past-max (capacity / COUNTER_LENGTH), used as the
// upper bound in `for (i = 0; i < MaxCounterId; i++)` iteration loops throughout
// the codebase. So a counterId equal to MaxCounterId is out of bounds — it would
// produce CounterOffset(counterId) == capacity and a buffer-overrun read.
// Java's maxCounterId is one less (inclusive max) and uses `> maxCounterId` here.
if (counterId < 0 || counterId >= MaxCounterId)
{
throw new System.ArgumentException("Counter id " + counterId + " out of range: maxCounterId=" + MaxCounterId);
}
Expand Down
Loading