Fix ValidateCounterId so an ID exactly equal to MaxCounterId also fails#143
Draft
strangelydim wants to merge 1 commit intomasterfrom
Draft
Fix ValidateCounterId so an ID exactly equal to MaxCounterId also fails#143strangelydim wants to merge 1 commit intomasterfrom
strangelydim wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR being created as a draft for discussion.
Java's maxCounterId is set to:
whereas .NET's is:
The better fix, IMO, is to change .NET to match Java, so "max counter ID" really is the max counter ID, not one higher than the max ID.
However, it's a public value, and users might already have code that uses it, so that would be a potentially breaking change.
The change in this PR is the simpler, non-breaking thing we could do. Which do we prefer?