Conversation
The HTTP client would hang when trying to read a response body for 204 No Content responses with keep-alive connections. This is because the client incorrectly attempted to read a body based solely on the request method, without considering the response status code. Per RFC 9110 Section 6.3, responses with status codes 204 (No Content), 304 (Not Modified), and 1xx (Informational) must not contain a message body, regardless of what headers might suggest. Fixes ziglang#25181
andrewrk
self-requested a review
September 18, 2025 02:50
Member
|
Thanks for the additional test case. Bookmarking this for a morning when I've a fresh mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP client would hang when trying to read a response body for 204 No Content responses with keep-alive connections. This is because the client incorrectly attempted to read a body based solely on the request method, without considering the response status code.
Per RFC 9110 Section 6.3, responses with status codes 204 (No Content), 304 (Not Modified), and 1xx (Informational) must not contain a message body, regardless of what headers might suggest.
Fixes #25181