Added Support For Storage Site API's#2206
Conversation
|
coverage: 77.373%. first build — storagesite into master |
vontedduchaithra
force-pushed
the
storagesite
branch
from
9a771ee to
f655fe4
Compare
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
vontedduchaithra
force-pushed
the
storagesite
branch
from
f655fe4 to
bfe26c0
Compare
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
| @@ -0,0 +1,439 @@ | |||
| # Copyright 2025 IBM Corp. All Rights Reserved. | |||
There was a problem hiding this comment.
Please change the copyright year to the current year.
| within the FICON storage configuration of a DPM-enabled :term:`CPC`. | ||
| A primary site (named "Primary Site") exists by default and cannot be | ||
| deleted. An alternate site at a remote location can be created and | ||
| deleted. |
There was a problem hiding this comment.
The existing test does not distinguish sufficiently between the real world storage site and the HMC object representing it.
Also, it seems to suggest that the way one can detect the storage site object for the primary site is by name="Primary Site", when it actually should be detected by type="primary". Also, the name property is writeable, so the name is not a reliable way to detect the primary site object.
To address both of that, I suggest to change the two sentences starting at "A primary site (named "Primary Site") exists by default" to:
A Storage Site object with `type="primary"` always exists for the primary
site and cannot be deleted. Additional Storage Site objects can be created
and deleted.
| @@ -0,0 +1,294 @@ | |||
| # Copyright 2025 IBM Corp. All Rights Reserved. | |||
There was a problem hiding this comment.
Please change the copyright year to the current year.
| @@ -0,0 +1,318 @@ | |||
| # Copyright 2025 IBM Corp. All Rights Reserved. | |||
There was a problem hiding this comment.
Please change the copyright year to the current year.
| A storage site describes a location that houses a set of storage switches and | ||
| storage subsystems. A primary site with a default name of "Primary Site", | ||
| local to the CPC, exists by default and cannot be deleted. An alternate site, | ||
| typically at a remote location, can be created. |
There was a problem hiding this comment.
The existing test does not distinguish sufficiently between the real world storage site and the HMC object representing it.
Also, it seems to suggest that the way one can detect the storage site object for the primary site is by name="Primary Site", when it actually should be detected by type="primary". Also, the name property is writeable, so the name is not a reliable way to detect the primary site object.
To address both of that, I suggest to change the two sentences starting at "A primary site (named "Primary Site") exists by default" to:
A Storage Site object with `type="primary"` always exists for the primary
site and cannot be deleted. Additional Storage Site objects can be created
and deleted.
|
|
||
| # Resource properties that are supported as filter query parameters. | ||
| query_props = [ | ||
| 'cpc-uris', |
There was a problem hiding this comment.
The query parameter for the cpc-uris property is named cpc-uri.
So far, the assumption in the code is that the property has the same name as the query parameter.
That is not the case here, so you need to add special handling of that to the code, and also make sure there is a testcase for that case. The property name here should probably remain cpc-uris because that will be the property that is specified in the filter_args parameter of list(). The special handling is probably in _list_with_operation() or in divide_filter_args(), but these are very generic methods/functions and you don't want to hard code that case there. I think it requires some more class variable in the StorageSiteManager object to provide the necessary data to these functions. You need to work out how you want to handle that, and we can discuss it in the weekly meeting.
| # Resource properties that are supported as filter query parameters. | ||
| query_props = [ | ||
| 'cpc-uris', | ||
| 'name', |
There was a problem hiding this comment.
There is an additional supported query property: type.
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
3 participants
No description provided.