fix: enhance delegate model interaction with afterEntityMutation plugin support in child updates#2369
Conversation
…in support in child updates
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe PR narrows the child-update filter in delegate updates to use only base-model ID fields derived from the base update result and adds an end-to-end test that exercises delegate child-model updates when an Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ymc9
left a comment
There was a problem hiding this comment.
Hi @genu , thanks for making the fix, and I think it's a good safety measure. A deeper problem is, when mutation hooks are used in plugins, the underlying query executor "forces injecting" a return * clause, resulting in more fields returned and breaking some assumptions on the upper layer. I'll see I can make a separate PR on the root cause.
I've merged your branch with the latest "dev" and refined the comments a bit. Will merge once CI passes
Fixes #2367
Summary by CodeRabbit
Bug Fixes
Tests