Open
Conversation
derpixler
force-pushed
the
fixes-759-graceful-handling-unseeded-database
branch
from
0d1533f to
457b5c7
Compare
mgruner
reviewed
Apr 16, 2026
| <<: *zammad-service | ||
| command: ["zammad-railsserver"] | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-sf", "http://localhost:3000"] |
Collaborator
There was a problem hiding this comment.
ZAMMAD_RAILSSERVER_PORT is configurable. Are you sure that localhost is safe to get used here in the container?
Contributor
Author
There was a problem hiding this comment.
You're right — ZAMMAD_RAILSSERVER_PORT is documented. The healthcheck shouldn't hardcode 3000; I'll update it to http://127.0.0.1:${ZAMMAD_RAILSSERVER_PORT:-3000}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #759 - railsserver add healthcheck to check if localhost:3000 available