Skip to content

Deny pass null to CreateService::getTemplate() - #355

Open
KalimeroMK wants to merge 2 commits into
yiisoft:masterfrom
KalimeroMK:issue-313-deny-null-template
Open

Deny pass null to CreateService::getTemplate()#355
KalimeroMK wants to merge 2 commits into
yiisoft:masterfrom
KalimeroMK:issue-313-deny-null-template

Conversation

@KalimeroMK

Copy link
Copy Markdown
Contributor

Fix #313

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues #313

null is never passed to CreateService::getTemplate(), so the nullable type and the (string) cast are removed.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (8e1dcdb) to head (083ea14).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #355       +/-   ##
=============================================
+ Coverage      0.00%   96.39%   +96.39%     
  Complexity      311      311               
=============================================
  Files            20       20               
  Lines          1000      999        -1     
=============================================
+ Hits              0      963      +963     
+ Misses         1000       36      -964     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGELOG.md Outdated
@Tigrov Tigrov added the severity:BC breaking Breaks backwards compatibility label Aug 22, 2026
@vjik vjik added the status:ready for merge The pull request is OK to be merged. label Aug 23, 2026
@vjik vjik added this to the 3.0 milestone Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity:BC breaking Breaks backwards compatibility status:ready for merge The pull request is OK to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deny pass null to CreateService::getTemplate()

4 participants