Code review fixes: error handling, env vars, health check#565
Open
JiayangLai wants to merge 1 commit intoyeasy:masterfrom
Open
Code review fixes: error handling, env vars, health check#565JiayangLai wants to merge 1 commit intoyeasy:masterfrom
JiayangLai wants to merge 1 commit intoyeasy:masterfrom
Conversation
- .docker/docker-entrypoint.sh: add set -euo pipefail, use HOST/PORT env vars - 04_image/demo/multistage-builds/app.go: fix Printf formatting, add newline - 11_compose/demo/app/app.py: add health endpoint, env-based config, error handling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -euo pipefailand configurable HOST/PORT env vars to.docker/docker-entrypoint.sh04_image/demo/multistage-builds/app.go11_compose/demo/app/app.pyChanges
.docker/docker-entrypoint.shset -euo pipefail, HOST/PORT env vars04_image/demo/multistage-builds/app.go\n, removed trailing semicolon11_compose/demo/app/app.pydebug=Truesecurity risk, no error handlingTest plan
docker-entrypoint.shexits on errors🤖 Generated with Claude Code