Skip to content

Moved to C++17#1383

Open
JohanMabille wants to merge 1 commit into
xtensor-stack:masterfrom
JohanMabille:cxx_17
Open

Moved to C++17#1383
JohanMabille wants to merge 1 commit into
xtensor-stack:masterfrom
JohanMabille:cxx_17

Conversation

@JohanMabille

@JohanMabille JohanMabille commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Antoine found the issue I was thinking about: #1267

@JohanMabille JohanMabille mentioned this pull request Jul 16, 2026
Draft
@DiamonDinoia

DiamonDinoia commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Sure, I'll have a look, we should change the docs here too then, I'll double check everything

@DiamonDinoia

DiamonDinoia commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hi I would update the docs here:

test/architectures/CMakeLists.txt:21   cxx_std_14 → cxx_std_17
README.md:46                            C++14 → C++17
docs/source/index.rst:72                C++14 → C++17

.github/workflows/cxx-versions.yml:17,43 still tests CMAKE_CXX_STANDARD=14 so this is obsolete now?
benchmark/CMakeLists.txt:38–48 still has the old C++14 fallback probe

I think we should fix these in this commit, then we an make changes.

DiamonDinoia
DiamonDinoia requested changes Jul 16, 2026
View reviewed changes

@DiamonDinoia DiamonDinoia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I added a comment before so could you read the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiamonDinoia DiamonDinoia DiamonDinoia requested changes
@AntoinePrv AntoinePrv AntoinePrv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohanMabille @DiamonDinoia @AntoinePrv