Skip to content

Add aggregate strategies support (lateral & grouped)#1

Draft
wtsnz wants to merge 6 commits into
mainfrom
feat/aggregate-strategies-split
Draft

Add aggregate strategies support (lateral & grouped)#1
wtsnz wants to merge 6 commits into
mainfrom
feat/aggregate-strategies-split

Conversation

@wtsnz
Copy link
Copy Markdown
Owner

@wtsnz wtsnz commented May 21, 2026

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Ultimately this came out of my last pr to ash_sqlite that adds aggregate support. After talking to Zach he brought up the idea that the different aggregate strategies should probably live in ash_sql instead of specifically inside of ash_sqlite. SQLite doesn't support aggregates based on lateral queries so instead we must implement a different strategy based on windows.

Two possible approaches going forward 1 OR 2:

  1. Keep the sqlite aggregate support in my last pr
    a. Add support for Aggregates ash-project/ash_sqlite#213
  2. Use the newer approach (PRs) that add aggregate strategies to ash_sql and updates ash_sqlite to implement them)
    a. This PR that adds the multiple aggregate strategies to ash_sql
    b. A PR that adds the consumption of the above into ash_sqlite Add Aggregate Support using ash_sql implementation ash_sqlite#5
    c. A tiny pr to ash_postgres that explicitly states the aggregate_strategy (wtsnz/ash_postgres@c02e86f)

The direction depends on what ash community want - I'll defer to them after asking

@wtsnz wtsnz marked this pull request as draft May 21, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant