Change CookieJar behaviors ahead of the async conversion - #26106
Open
crazytonyli wants to merge 5 commits into
Open
crazytonyli wants to merge 5 commits into
crazytonyli wants to merge 5 commits into
Conversation
Auth cookie checks now read all cookies and match them against the URL in shared code, instead of each jar matching URLs on its own. HTTPCookieStorage no longer uses its built-in URL matching, and every WebKit cookie read gets the timeout that guards against getAllCookies not calling back.
WebKit reports each deletion on the main thread, so waiting for the deletions there always ran into the two-second timeout. The completion handler is now called when the deletions finish, without a timeout.
The WebKit cookie store set cookies from last to first, while HTTPCookieStorage sets them from first to last. Both now use the same order, so the same cookie wins when the list holds duplicates.
The tests did not wait for their cookies to be set and let the data store that owns the cookie store be deallocated, so they were marked as expected failures. They now pass without that marker.
The request authenticator returned without calling its completion handler, so the web view never loaded. It now hands back the plain request, as the other failure paths do.
crazytonyli
added this pull request to stack #26107
October 1, 2026 02:43
Collaborator
Generated by 🚫 Danger |
crazytonyli
changed the title
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34801 | |
| Version | PR #26106 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 6055290 | |
| Installation URL | 1obbutve4iqso |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34801 | |
| Version | PR #26106 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 6055290 | |
| Installation URL | 2anvhhdqrs9mg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One commit per change: