Skip to content

Fix JetpackIntents signing for device builds#25497

Open
jkmassel wants to merge 1 commit intotrunkfrom
jkmassel/fix-jetpack-intents-signing
Open

Fix JetpackIntents signing for device builds#25497
jkmassel wants to merge 1 commit intotrunkfrom
jkmassel/fix-jetpack-intents-signing

Conversation

@jkmassel
Copy link
Copy Markdown
Contributor

Summary

  • Adds device-specific (sdk=iphoneos*) DEVELOPMENT_TEAM and PROVISIONING_PROFILE_SPECIFIER overrides for the JetpackIntents extension Debug configuration
  • Fixes code signing when building to a physical device

Test plan

  • Build the Jetpack scheme to a physical device and verify JetpackIntents extension signs correctly

@dangermattic
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@jkmassel jkmassel requested a review from mokagio April 14, 2026 21:22
Add device-specific development team and provisioning profile overrides
for the JetpackIntents extension Debug configuration.
@jkmassel jkmassel force-pushed the jkmassel/fix-jetpack-intents-signing branch from 3939da1 to 2e3035a Compare April 14, 2026 21:22
@@ -3961,6 +4328,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.automattic.jetpack.JetpackIntents;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "Jetpack iOS Development Intents";
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "Jetpack iOS Development Intents Extension";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name changed here, which is causing breakage

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkmassel did you consider overriding the line above so it applies to all? Not that it matters, but it would remove the outdate name

				"PROVISIONING_PROFILE_SPECIFIER" = "Jetpack iOS Development Intents Extension";

@jkmassel jkmassel enabled auto-merge April 14, 2026 21:26
@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number32014
VersionPR #25497
Bundle IDorg.wordpress.alpha
Commit2e3035a
Installation URL3tevngp43pvmg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number32014
VersionPR #25497
Bundle IDcom.jetpack.alpha
Commit2e3035a
Installation URL44gm1snnk1kcg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants