Skip to content

Reader: Reapply fix for issue with link color in dark mode#25471

Open
kean wants to merge 1 commit intotrunkfrom
fix/reader-colors-links-dark-mode
Open

Reader: Reapply fix for issue with link color in dark mode#25471
kean wants to merge 1 commit intotrunkfrom
fix/reader-colors-links-dark-mode

Conversation

@kean
Copy link
Copy Markdown
Contributor

@kean kean commented Mar 31, 2026

This was lost during merge of the release branch. Makes sure the color is again blue – standard for links on the web.

Screenshot 2026-03-31 at 5 30 52 PM

@kean kean added this to the 26.9 milestone Mar 31, 2026
@kean kean added the Reader label Mar 31, 2026
@sonarqubecloud
Copy link
Copy Markdown

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number31896
VersionPR #25471
Bundle IDcom.jetpack.alpha
Commitf78afd9
Installation URL16eat0nruj96g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number31896
VersionPR #25471
Bundle IDorg.wordpress.alpha
Commitf78afd9
Installation URL49eii9d1mni58
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean requested a review from jkmassel April 1, 2026 14:40
Copy link
Copy Markdown
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the correct fix – the CSS from the server already handles this, what we should probably be doing is just removing the override from this CSS file and relying on the remote one?

@kean
Copy link
Copy Markdown
Contributor Author

kean commented Apr 8, 2026

I'm not sure this is the correct fix – the CSS from the server already handles this, what we should probably be doing is just removing the override from this CSS file and relying on the remote one?

The colors are controlled by the app and its Reading Preferences. Here's another related PR: #25391 that demonstrates the issues related to the CSS provided by the server. The following override in the CSS vended by the server needs to eventually be removed, but probably only after the apps ship.

@kean kean requested a review from jkmassel April 8, 2026 13:03
@jkmassel
Copy link
Copy Markdown
Contributor

We probably need to give this a bit more thought, because the default style should be green (per the decisions made as part of Automattic/wp-calypso#107138) but the others themes should definitely not be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants