You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the correct fix – the CSS from the server already handles this, what we should probably be doing is just removing the override from this CSS file and relying on the remote one?
I'm not sure this is the correct fix – the CSS from the server already handles this, what we should probably be doing is just removing the override from this CSS file and relying on the remote one?
The colors are controlled by the app and its Reading Preferences. Here's another related PR: #25391 that demonstrates the issues related to the CSS provided by the server. The following override in the CSS vended by the server needs to eventually be removed, but probably only after the apps ship.
We probably need to give this a bit more thought, because the default style should be green (per the decisions made as part of Automattic/wp-calypso#107138) but the others themes should definitely not be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was lost during merge of the release branch. Makes sure the color is again blue – standard for links on the web.