Use consistent tab styling across the app#22798
Draft
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Make WordPress.TabLayout non-uppercase by default and drop explicit .uppercase() calls on Compose tab labels so every tab renders in the same mixed-case style. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Set tabMode=auto, tabGravity=fill, tabInlineLabel=true, tabMaxWidth=0dp on the shared WordPress.TabLayout style so every TabLayout fills the screen width when tabs fit, scrolls horizontally when they don't, and keeps labels on a single line. Remove the now-redundant per-layout overrides. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
These two tab layouts no longer use any app:* attributes after the tab-styling cleanup in this branch, so the xmlns:app declarations were unused. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The branch already removed the last reference to this color in the main flavor; the Jetpack-flavor overrides in values/ and values-night/ were orphaned, which lint reported as UnusedResources. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes CMM-2045
Normalizes tab styling so every tab layout in the app - both XML and Compose - uses the same stying. Prior to this PR we had tab layouts using different label colors, capitalization, indicator colors, and sizing.
Affected screens:
Testing instructions
Checking all of the above screens isn't necessary since the main change was to remove per-screen styling in favor of a shared style. I recommend just choosing a few screens and verifying the tab styling is consistent.