Skip to content

Handle OCSP_WANT_READ returned from DoTls13HandShakeMsgType#9995

Open
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl:zd/21341
Open

Handle OCSP_WANT_READ returned from DoTls13HandShakeMsgType#9995
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl:zd/21341

Conversation

@julek-wolfssl
Copy link
Member

ZD21341

@julek-wolfssl julek-wolfssl self-assigned this Mar 17, 2026
Copilot AI review requested due to automatic review settings March 17, 2026 11:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the TLS 1.3 handshake path and test harness to correctly treat nonblocking OCSP retrieval as a retriable condition (OCSP_WANT_READ), and adds a regression test to exercise that path under small max-fragment settings.

Changes:

  • Treat OCSP_WANT_READ as a retryable handshake condition in TLS 1.3 message processing and the memio handshake test helper.
  • Add a TLS 1.3 nonblocking OCSP + low max-fragment-length regression test.
  • Update GitHub Actions config to run an OCSP job with WOLFSSL_NONBLOCK_OCSP and max-fragment enabled.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/api/test_ocsp.h Exposes the new OCSP/TLS 1.3 nonblocking MFL regression test.
tests/api/test_ocsp.c Adds the new nonblocking OCSP callback simulation test under TLS 1.3 with low MFL.
tests/api.c Treats OCSP_WANT_READ as a retryable error during memio handshakes.
src/tls13.c Treats OCSP_WANT_READ like WC_PENDING_E when replaying a fragmented handshake message.
.github/workflows/os-check.yml Enables a CI configuration that exercises nonblocking OCSP + max-fragment.
Comments suppressed due to low confidence (2)

tests/api.c:1

  • OCSP_WANT_READ is used unconditionally in the handshake helper. If this file is compiled in configurations where OCSP_WANT_READ is not defined (e.g., OCSP/nonblock OCSP disabled), this can cause a build failure. Consider guarding the OCSP_WANT_READ check with #ifdef OCSP_WANT_READ / #if defined(WOLFSSL_NONBLOCK_OCSP) (or use a helper macro) so non-OCSP builds still compile.
    tests/api.c:1
  • Same issue as above: this unconditional reference to OCSP_WANT_READ can break builds where the symbol isn’t defined. Apply the same conditional compilation strategy here as well.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants