Skip to content

Disallow wildcard partial domains when using MatchDomainName.#9991

Open
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
kareem-wolfssl:zd21354_2
Open

Disallow wildcard partial domains when using MatchDomainName.#9991
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
kareem-wolfssl:zd21354_2

Conversation

@kareem-wolfssl
Copy link
Contributor

Description

Fixes zd#21354

Testing

Built in tests + provided reproducer.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@kareem-wolfssl kareem-wolfssl self-assigned this Mar 16, 2026
@kareem-wolfssl kareem-wolfssl added the For This Release Release version 5.9.0 label Mar 16, 2026
Copilot AI review requested due to automatic review settings March 16, 2026 23:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates MatchDomainName to reject “partial domain” wildcard patterns in strict left-wildcard matching, aligning behavior with the intended *.domain.com-only rule (fixes zd#21354).

Changes:

  • Disallows patterns like *domain.com when leftWildcardOnly is enabled.
  • Enforces that the character following the wildcard must be . (i.e., *.domain.com).
Comments suppressed due to low confidence (1)

src/internal.c:1

  • This check assumes pattern points to the character immediately after the *. If pattern still points at the * (or at some other position due to surrounding parsing), this would incorrectly reject all strict-left-wildcard patterns. Consider making the check explicitly reference the character after the wildcard (e.g., using an index/offset relative to the wildcard position) or adjust the code so it unambiguously advances past * before this check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@JacobBarthelmeh
Copy link
Contributor

Retest this please Jenkins. Error during multi-test pid 44258 for port 24539 exited before creating ready file. bailing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants