Check raw pubkey length in wc_ecc_import_x963 before copying to it for KCAPI case.#9988
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a bounds check to prevent overrunning key->pubkey_raw when importing an X9.63 public key under the WOLFSSL_KCAPI_ECC build configuration (fix for zd#21356).
Changes:
- Guard
XMEMCPY(key->pubkey_raw, ...)with a length check for the KCAPI ECC case. - Return an error when the provided public key blob is larger than the destination buffer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
JacobBarthelmeh
approved these changes
Mar 16, 2026
Contributor
|
Retest this please Jenkins |
JacobBarthelmeh
added
For This Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21356
Thanks to Haruto Kimura (Stella) for the report.
Testing
Built in tests, provided reproducer
Checklist