Automatically turn on LMS / XMSS full hash#9946
Conversation
When WOLFSSL_NO_HASH_RAW is definied due to hardware hash offload, turn on LMS anx XMSS full hash. Without this they will not compile automatically when there is hardware SHA acceleration.
There was a problem hiding this comment.
Pull request overview
This PR ensures XMSS and LMS automatically switch to “full hash” API usage when WOLFSSL_NO_HASH_RAW is enabled (e.g., due to hardware hash offload), preventing build failures when raw-hash access is unavailable.
Changes:
- Auto-define
WC_XMSS_FULL_HASHwhenWOLFSSL_NO_HASH_RAWis set. - Auto-define
WC_LMS_FULL_HASHwhenWOLFSSL_NO_HASH_RAWis set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wolfssl/wolfcrypt/wc_xmss.h | Adds conditional auto-enable of XMSS full-hash mode when raw hash is disabled. |
| wolfssl/wolfcrypt/wc_lms.h | Adds conditional auto-enable of LMS full-hash mode when raw hash is disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
@LinuxJedi please review copilot and CI errors |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Jenkins: retest this please, Valgrind failed, likely unrelated, can't even see why at a glance. |
When WOLFSSL_NO_HASH_RAW is defined due to hardware hash offload, turn on LMS anx XMSS full hash. Without this they will not compile automatically when there is hardware SHA acceleration.