PPC64 Assembly: ELF V1 headers added. Little-endian asm added.#10871
PPC64 Assembly: ELF V1 headers added. Little-endian asm added.#10871SparkiDev wants to merge 1 commit into
Conversation
|
Code generated by PR: |
|
Jenkins: retest this please |
SparkiDev
force-pushed
the
ppc64_le_and_elf1_fix
branch
from
810046d to
71ffa4e
Compare
|
Jenkins: retest this please FIPS-ready (aborted) x2 |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10871
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
| * key-setup path before any AES_*_crypto use. */ | ||
| static void Aes_SetCrypto(void) | ||
| { | ||
| if (aes_ppc64_use_crypto < 0) { |
There was a problem hiding this comment.
Fixed and for other platforms and SHA2 as well.
ELF V1 headers are need for cross-compiles. PPC64 is big or little endian so assembly code modified to be able to be built for both. Fix wiring of vector AES implementations in aes.c.
SparkiDev
force-pushed
the
ppc64_le_and_elf1_fix
branch
from
71ffa4e to
3f3ebca
Compare
| * key-setup path before any AES_*_crypto use. */ | ||
| static void Aes_SetCrypto(void) | ||
| { | ||
| if (aes_ppc64_use_crypto < 0) { |
There was a problem hiding this comment.
Fixed and for other platforms and SHA2 as well.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10871
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
|
Jenkins: retest this please |
3 participants
Description
ELF V1 headers are need for cross-compiles.
PPC64 is big or little endian so assembly code modified to be able to be built for both. Fix wiring of vector AES implementations in aes.c.
Testing
Tested big-/little-endian PPC64 with assembly code.