Skip to content

Fix regressions (fast math MAX_ENCODED_SIG_SZ; DTLS export IV buffer size) #10229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SparkiDev merged 2 commits into from
Apr 15, 2026
+4 −2
Merged

Fix regressions (fast math MAX_ENCODED_SIG_SZ; DTLS export IV buffer size) #10229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95c177b
Set MAX_ENCODED_SIG_SZ to FP_MAX_BITS / 16 rather than / 8
mattia-moffa Apr 15, 2026
bd3cf10
DTLS export: cap IV size at buffer size
mattia-moffa Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,9 @@ static int ExportKeyState(WOLFSSL* ssl, byte* exp, word32 len, byte ver,
XMEMCPY(exp + idx, keys->aead_exp_IV, AEAD_MAX_EXP_SZ);
idx += AEAD_MAX_EXP_SZ;

sz = (small)? 0: ssl->specs.iv_size;
sz = (small) ? 0 :
(ssl->specs.iv_size > AEAD_MAX_IMP_SZ ? AEAD_MAX_IMP_SZ
: ssl->specs.iv_size);
if (idx + (sz * 2) + OPAQUE8_LEN > len) {
WOLFSSL_MSG("Buffer not large enough for imp IVs");
return BUFFER_E;
Expand Down
2 changes: 1 addition & 1 deletion wolfssl/wolfcrypt/types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2315,7 +2315,7 @@ enum Max_ASN {
MAX_ENCODED_SIG_SZ = 5120,
#elif !defined(NO_RSA)
#if defined(USE_FAST_MATH) && defined(FP_MAX_BITS)
MAX_ENCODED_SIG_SZ = FP_MAX_BITS / 8,
MAX_ENCODED_SIG_SZ = FP_MAX_BITS / 16,
#elif (defined(WOLFSSL_SP_MATH_ALL) || defined(WOLFSSL_SP_MATH)) && \
defined(SP_INT_BITS)
MAX_ENCODED_SIG_SZ = WC_BITS_TO_BYTES(SP_INT_BITS),
Expand Down
Loading