Merged
Conversation
3afd5af to
ce27509
Compare
8461d97 to
23f39ed
Compare
1. Unaligned Buffer Tests Verify correct output when input/output buffers are byte-offset by 1, 2, and 3 bytes. - AES-CBC, AES-CTS, AES-CTR, AES-GCM, AES-CCM, AES-XTS - ChaCha20, ChaCha20-Poly1305 2. In-Place (Overlapping) Buffer Tests Verify correct output when out == in (same pointer for input and output). - AES-CTS, AES-GCM, AES-CCM, AES-XTS - ChaCha20, ChaCha20-Poly1305 3. Cross-Cipher Verification Tests Verify that a higher-level mode produces identical output when manually reconstructed from a lower-level primitive (typically AES-ECB + XOR). - AES-CBC (= ECB + XOR chaining) - AES-CFB (= ECB(ciphertext feedback) + XOR) - AES-OFB (= ECB(output feedback) + XOR) - AES-CTR (= ECB(counter) + XOR with big-endian increment) - AES-GCM (ciphertext portion = CTR starting at counter J0+1) - ChaCha20-Poly1305 (ciphertext = raw ChaCha20 keystream XOR; tag = independent Poly1305) 4. Counter Overflow Tests Verify correct carry propagation when the internal block counter wraps around. - AES-CTR (32-bit big-endian carry across 4 bytes: 0xFFFFFFFE → wrap) - ChaCha20 (32-bit counter: 0xFFFFFFFF → 0x00000000) 5. AEAD Edge Case Tests Verify correct behavior for empty inputs, empty AAD, and invalid auth tag rejection. - Ascon-AEAD128 - AES-CCM - ChaCha20-Poly1305 6. Non-Standard Parameter Tests Verify behavior outside the common fast path. - AES-GCM: non-96-bit nonce lengths (1-byte, 60-byte, variable-length loop, zero-length rejection) 7. Streaming API State Tests Verify mid-stream state behavior and re-initialization after a final call. - AES-GCM stream, AES-XTS stream - ChaCha20-Poly1305 stream
23f39ed to
c905033
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10226
No scan targets match the changed files in this PR. Review skipped.
dgarske
reviewed
Apr 15, 2026
Contributor
dgarske
left a comment
There was a problem hiding this comment.
Why are we putting all these into our unit tests and not in the portable wolfcrypt/test/test.c?
Contributor
Author
|
test.c is made to be run on embedded platforms. |
dgarske
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
./configure --disable-shared --enable-all --enable-experimental --enable-rc2 --enable-aesofb --enable-aescts --enable-ascon