Skip to content

Add Negative testing and Validation for wolfPKCS11#179

Draft
aidangarske wants to merge 15 commits intowolfSSL:masterfrom
aidangarske:fenrir-fixes-2
Draft

Add Negative testing and Validation for wolfPKCS11#179
aidangarske wants to merge 15 commits intowolfSSL:masterfrom
aidangarske:fenrir-fixes-2

Conversation

@aidangarske
Copy link
Copy Markdown
Member

F-2379, F-2380, F-2386, F-2375, F-2389, F-2368, F-2369, F-2381, F-2382, F-2376, F-2390

…NCRYPT/CKA_DECRYPT attribute enforcement in C_EncryptInit/C_DecryptInit
…IGN/CKA_VERIFY attribute enforcement in C_SignInit/C_VerifyInit
…ERIFY attribute enforcement in C_VerifyRecoverInit
…ngle-shot C_Encrypt output length for block-aligned inputs
…IVE=TRUE and CKA_EXTRACTABLE=FALSE for private keys
…RAP/CKA_UNWRAP attribute enforcement in C_WrapKey/C_UnwrapKey
…e-shot NULL size query checking wrong parameter
@aidangarske aidangarske self-assigned this Apr 8, 2026
Copilot AI review requested due to automatic review settings April 8, 2026 19:31

This comment was marked as resolved.

@LinuxJedi
Copy link
Copy Markdown
Member

@wolfSSL-Fenrir-bot review

wolfSSL-Fenrir-bot

This comment was marked as resolved.

  - src/internal.c — WP11_Object_Find private-access check now uses slot->lock consistently (matches WP11_Slot_IsLoggedIn pattern) instead of conditionally using token.lock only
  for non-token objects
  - tests/pkcs11mtt.c — Added CKA_SENSITIVE to test key templates so they work with the new CKA_SENSITIVE=TRUE default from F-2368. When extractable=TRUE, sensitive is set FALSE
  so tests can read key values. When extractable=FALSE, sensitive stays TRUE matching the hardened default. Applied to test_attribute, get_generic_key, get_rsa_priv_key,
  get_ecc_priv_key, and get_dh_priv_key.
@aidangarske aidangarske removed the request for review from wolfSSL-Fenrir-bot April 9, 2026 17:57
@aidangarske aidangarske requested review from Copilot and removed request for Copilot April 9, 2026 20:17
@aidangarske aidangarske requested review from Copilot and removed request for Copilot April 9, 2026 22:41
Copilot AI review requested due to automatic review settings April 9, 2026 23:28
@aidangarske aidangarske review requested due to automatic review settings April 9, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants