skill added for RNN android and iOS#8238
Merged
markdevocht merged 4 commits intomasterfrom Mar 5, 2026
Merged
Conversation
yedidyak
previously approved these changes
Feb 26, 2026
Contributor
yedidyak
left a comment
There was a problem hiding this comment.
LGTM! All three factual issues from the initial review have been fixed, and the skill is now available across Cursor, Claude Code, and GitHub Copilot.
One minor note: the relative ARCHITECTURE.md links (../../ARCHITECTURE.md) resolve correctly from .cursor/ and .claude/ but are off by one level from .github/skills/rnn-codebase/ (needs ../../../). Not a blocker.
🤖 Generated with Claude Code
yedidyak
approved these changes
Feb 26, 2026
yedidyak
pushed a commit
that referenced
this pull request
Mar 12, 2026
* skill added for RNN android and iOS * update for Skills and added to multiple agent folders * fixing relative path for github copilot
markdevocht
added a commit
that referenced
this pull request
Mar 15, 2026
* skill added for RNN android and iOS (#8238) * skill added for RNN android and iOS * update for Skills and added to multiple agent folders * fixing relative path for github copilot * Add skill document for RN version upgrade process Formalises the process of adding new React Native version support, validated against PRs for RN 0.80 through 0.84. Covers CI setup, dependency analysis, native compilation fixes, and 10 common pitfalls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Update RN upgrade skill: prefer __has_include and RCT_REMOVE_LEGACY_ARCH Learned from PR #8244's approach to iOS arch guards: - Use __has_include for conditional imports (forward-compatible) - Use #ifndef RCT_REMOVE_LEGACY_ARCH for legacy code blocks (RN 0.84+) - Added "Research Before Fixing" phase: investigate better approaches from the target RN version before pattern-matching on existing code - Updated all fix patterns and pitfalls to reflect these techniques Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: mark.dev <50657916+markdevocht@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RNN skill gives the AI a mental map of the codebase so it doesn't have to discover the architecture from scratch every conversation. Specifically: