Skip to content

refactor(conversation): share file thumbnail presentation (WPB-29908) - #23049

Merged
cristianoliveira merged 1 commit into
mainfrom
WPB-29908-shared-file-preview
Nov 12, 2026
Merged

cristianoliveira merged 1 commit into
mainfrom
WPB-29908-shared-file-preview

Conversation

@cristianoliveira

@cristianoliveira cristianoliveira commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor
TaskWPB-29908 [Web] E2e PDF preview on chat

Problem

Cells owns thumbnail button/image presentation that encrypted chat previews also need. Duplicating it would let styling and accessibility behavior drift.

Solution

  • Extract the existing Cells presentation into FileCard.Preview.
  • Keep Cells loading/error overlays, image state, and preview-dialog action in its existing adapter.
  • Add regressions for native button behavior, image visibility/errors, overlays, and the existing Cells dialog/loading/error paths.

This is a standalone refactor of existing Cells behavior. It introduces no encrypted PDF transfer or chat preview behavior.

Reference

https://wearezeta.atlassian.net/browse/WPB-29908

@cristianoliveira cristianoliveira added the semver:patch Bug fix, dependency update or other released-product change. Next release increments PATCH label Nov 11, 2026
@cristianoliveira
cristianoliveira force-pushed the WPB-29908-shared-file-preview branch 2 times, most recently from 3b70fbf to 18f237e Compare November 11, 2026 13:46
@arjita-mitra
arjita-mitra force-pushed the WPB-29908-shared-file-preview branch from 18f237e to 1e12c6b Compare November 12, 2026 08:44
@cristianoliveira
cristianoliveira added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 642526b Nov 12, 2026
17 checks passed
@cristianoliveira
cristianoliveira deleted the WPB-29908-shared-file-preview branch November 12, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch Bug fix, dependency update or other released-product change. Next release increments PATCH

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants