Update JavaScript codebase to use ESM and vite #451
Draft
Abijeet wants to merge 1 commit intouse-localecomparefrom
Draft
Update JavaScript codebase to use ESM and vite #451Abijeet wants to merge 1 commit intouse-localecomparefrom
Abijeet wants to merge 1 commit intouse-localecomparefrom
Conversation
Abijeet
force-pushed
the
esm-module
branch
4 times, most recently
from
e2ea721 to
0ea91ee
Compare
santhoshtr
reviewed
Oct 14, 2025
Dropped support for Node.js 16, 18. Updated ESLint to v9 since assert is not supported in v8. See: eslint/eslint#15305 Dropping support for Node v16, v18 should be fine as they are both EOL. Consequently had to drop support for Wikimedia/eslint rules as it doesn't yet support ESLint v9. Used vite to bundle the library for browser usage. Bug: https://phabricator.wikimedia.org/T407180 Change-Id: I44dee29b49804da5a13d986352148931baf7cb34
Abijeet
changed the title
Member
Author
|
Tested this using |
santhoshtr
reviewed
May 7, 2026
| "eslint-config-wikimedia": "0.31.0", | ||
| "mocha": "10.6.0" | ||
| "globals": "16.4.0", | ||
| "mocha": "10.6.0", |
Member
There was a problem hiding this comment.
Now that node has native test runner , I would drop mocha dependency. in npm ecosystem, any removal of depdencies are always good
| }, | ||
| "engine": { | ||
| "node": ">=16.0.0" | ||
| "node": ">=20.10.0" |
Member
There was a problem hiding this comment.
Since we are using vite, we can use current lts version of node here. v24 is good. https://nodejs.org/en/about/previous-releases
Node 20 is already end of life
| "mocha": "10.6.0" | ||
| "globals": "16.4.0", | ||
| "mocha": "10.6.0", | ||
| "vite": "6.3.7" |
| }, | ||
| "license": "GPL-2.0-or-later", | ||
| "scripts": { | ||
| "test": "mocha tests/js/*.js", |
Member
There was a problem hiding this comment.
"test": "node --test tests/js/*.js"
will do the testing
| strategy: | ||
| matrix: | ||
| node-v: [16.x, 18.x, 20.x] | ||
| node-v: [20.x, 22.x, 24.x] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropped support for Node.js 16, 18.
Updated ESLint to v9 since assert is not supported in v8. See:
eslint/eslint#15305
Dropping support for Node v16, v18 should be fine as they are both EOL.
Consequently had to drop support for Wikimedia/eslint rules as it
doesn't yet support ESLint v9.
Used vite to bundle the library for browser usage.
Bug: https://phabricator.wikimedia.org/T407180
Change-Id: I44dee29b49804da5a13d986352148931baf7cb34