Task: Add accessibility tagging support for Wellcome Funding Platform#1
Task: Add accessibility tagging support for Wellcome Funding Platform#1stuartwilkes wants to merge 38 commits intowellcome-mainfrom
Conversation
# Conflicts: # build/pdfmake.js # build/pdfmake.js.map # build/pdfmake.min.js # build/pdfmake.min.js.map
…ge in changes from version 0.2.23
stuartwilkes
changed the title
There was a problem hiding this comment.
Pull request overview
Adds PDF accessibility tagging support (logical structure tree + tagged content) for the Wellcome Funding Platform fork of pdfmake, enabling richer semantics for screen readers and assistive tooling.
Changes:
- Introduces tagged PDF structure generation in
src/printer.js(Document/Sect/TOC, paragraphs/headings, lists, tables, figures, and link struct handling). - Annotates list items and (conditionally) table cells in
src/layoutBuilder.jsto carry metadata needed for tagging during rendering. - Adjusts build/runtime behavior (keeps console statements in minified output; supports iterating multi-page unbreakable block fragments; forked package metadata).
Reviewed changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.config.js | Changes Terser compression to preserve console output in minified bundles. |
| src/printer.js | Implements the bulk of tagged-PDF rendering: structure tree creation, list/table/TOC/figure/link tagging, and artifact marking. |
| src/pageElementWriter.js | Changes unbreakable-block commit behavior to iterate across multiple internal pages. |
| src/layoutBuilder.js | Adds list/table annotation metadata and attaches _node to all lines for tagging. |
| src/elementWriter.js | Makes unbreakable context height calculation resilient to different page shape fields. |
| src/3rd-party/svg-to-pdfkit/source.js | Large vendor file rewrite (appears to be a full-file replacement). |
| package.json | Renames/scopes the package and bumps major version; updates repository/links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 11 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Not related to accessibility - this is migrated in from the patch we apply in production.
What does this change?
Adds support for accessibility tagging
How to test
How can we measure success?
Have we considered potential risks?