Repository navigation
Conversation
…nd '... Read more' text are overlapped
…t in a link Each LinkAnnotation in BasicText becomes a box sized to the bounding rect of the link with Compose's 48dp minimum touch target. A link that wraps onto the next line therefore swallows the taps on "Read more", on other words, and even on the content padding. Wrapping the whole text in a LinkAnnotation fixed only the taps on glyphs, and it also dropped the ripple and exposed the whole text to TalkBack as one link. Instead, provide a ViewConfiguration without the minimum touch target to the text while the whole text is toggleable and contains links, so that the links receive only the taps on their glyphs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The listeners of the read more and read less links were created in the plain helper functions, so every recomposition made new ones. LinkAnnotation.Clickable compares listeners by identity, which made currentText a new value and laid out the text again on every recomposition with toggleArea = More. Created in the composable, the compiler remembers them as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_before.mp4
_after.mp4