feat: support function for loader sunch as css-loader #58#132
Open
BUPTlhuanyu wants to merge 2 commits intowebpack:masterfrom
Open
feat: support function for loader sunch as css-loader #58#132BUPTlhuanyu wants to merge 2 commits intowebpack:masterfrom
BUPTlhuanyu wants to merge 2 commits intowebpack:masterfrom
Conversation
BUPTlhuanyu
force-pushed
the
master
branch
2 times, most recently
from
53d5aed to
6c96e01
Compare
Author
|
Hello, this issue is a common case |
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Maybe we should apply this logic for all unknown functions?
Author
The functions with scope vars will case an error, so i take a white list of function-name. |
alexander-akait
previously approved these changes
Dec 25, 2021
BUPTlhuanyu
commented
Dec 20, 2024
Author
BUPTlhuanyu
left a comment
BUPTlhuanyu
left a comment
There was a problem hiding this comment.
support function for loader
alexander-akait
approved these changes
Feb 5, 2025
| poolTimeout: env.watch ? Infinity : 2000, | ||
| }; | ||
| const workerPoolSass = { | ||
| workerAllowedFunctions: ['cssLoaderGetLocalIdent'], |
Member
There was a problem hiding this comment.
Just idea - why do not try to make it for all functions, I understand that it will not work when it using something from global scope, but anyway it will solve other simple cases
Sorry for delay. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
#58
function options like getLocalIdent cannot passed to the css-loader，so i need this function without scoped var.
Breaking Changes
Additional Info