fix: align Firefox minimum version with manifest capabilities - #2794
Merged
esokullu merged 1 commit intoAug 14, 2026
Merged
Conversation
|
@alectimison-maker is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns Firefox installation compatibility with manifest capabilities requiring Firefox 140+.
Changes:
- Raises Firefox’s minimum version from 109 to 140.
- Adds regression coverage for manifest capability version floors.
- Removes stale minimum-version references from documentation comments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/run.js |
Tests Firefox manifest version compatibility. |
src/firefox/manifest.json |
Sets Firefox minimum to 140.0. |
src/firefox/src/agent/agent.js |
Removes stale Firefox 109 reference. |
src/firefox/ARCHITECTURE.md |
Updates compatibility documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tabGroupsand AMO data-collection manifest capabilities.Motivation
The Firefox package declared support for Firefox 109 even though it now includes
storage.session(Firefox 115), thetabGroupspermission (Firefox 139), andbrowser_specific_settings.gecko.data_collection_permissions(Firefox 140 on desktop). Mozillaweb-ext lintreports this mismatch against the declared minimum.See #2793 and the Mozilla references linked there.
Design
The manifest minimum is raised to the newest capability required by the desktop package. Runtime feature detection around tab grouping remains unchanged. Raising the declared minimum is preferable to broad fallback work here because runtime guards cannot make an unsupported manifest permission or manifest key compatible with Firefox 109.
The regression test validates the complete dotted-numeric version and checks it against the known manifest capability floors.
Testing
npm test— passed (33 toolbar guard tests, 1693 main tests, 60 security checks)npm run test:fixtures— passed (165 tests)npx --yes web-ext@latest lint --source-dir src/firefox --output json— 0 errors, 0 notices; desktop minimum-version findings clearedgit diff --check upstream/main...HEAD— passedUnavailable browser check:
web-ext lintis reported separately and is not treated as a runtime browser check.Compatibility and risks
Firefox versions below 140 will no longer install the extension. This makes package metadata match capabilities already shipped; it does not remove support that the current package can reliably provide.
Mozilla lint still reports existing general warnings and one Firefox Android-specific compatibility warning. The current Firefox package targets the desktop sidebar, so Android support is not expanded in this change.
Scope
Closes #2793