Restrict supported Web eID token formats#125
Open
aarmam wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sander Kondratjev sander.kondratjev@nortal.com Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
|
mrts
requested changes
Jul 9, 2026
| protected Pattern getSupportedFormatPattern() { | ||
| return V1_SUPPORTED_TOKEN_FORMAT_PATTERN; | ||
| return V1_SUPPORTED_TOKEN_FORMAT_PREFIX.equals(format) | ||
| || "web-eid:1.0".equals(format); |
Member
There was a problem hiding this comment.
This will reject future backwards-compatible web-eid:1.x tokens. As written in the docs, minor format changes must be backwards-compatible within the same major version.
| ); | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = {"web-eid:1", "web-eid:1.0", "web-eid:1.1", "web-eid:1.10", "web-eid:1.999"}) |
Member
There was a problem hiding this comment.
We actually want "web-eid:1.2", "web-eid:1.10", "web-eid:1.999" etc pass here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mart Aarma mart.aarma@nortal.com