Open
Conversation
… in favour of `None`
…d-alpha Remove client-side default `alpha` param for hybrid queries
Fix/tokenize simple output
# Conflicts: # weaviate/proto/v1/v4216/v1/base_search_pb2.py # weaviate/proto/v1/v4216/v1/base_search_pb2.pyi # weaviate/proto/v1/v5261/v1/base_search_pb2.py # weaviate/proto/v1/v5261/v1/base_search_pb2.pyi # weaviate/proto/v1/v6300/v1/base_search_pb2.py # weaviate/proto/v1/v6300/v1/base_search_pb2.pyi
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
dirkkul
reviewed
Apr 23, 2026
# Conflicts: # weaviate/proto/v1/v4216/v1/base_search_pb2.py # weaviate/proto/v1/v4216/v1/base_search_pb2.pyi # weaviate/proto/v1/v5261/v1/base_search_pb2.py # weaviate/proto/v1/v5261/v1/base_search_pb2.pyi # weaviate/proto/v1/v6300/v1/base_search_pb2.py # weaviate/proto/v1/v6300/v1/base_search_pb2.pyi
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
bevzzz
reviewed
Apr 24, 2026
| return_metadata: The metadata to return for each object, defaults to `None`. | ||
| return_properties: The properties to return for each object. | ||
| return_references: The references to return for each object. | ||
| diversity_selection: Apply diversity selection (e.g. MMR) to the results. Requires Weaviate >= 1.37.0. |
Contributor
There was a problem hiding this comment.
Suggested change
| diversity_selection: Apply diversity selection (e.g. MMR) to the results. Requires Weaviate >= 1.37.0. | |
| diversity_selection: Apply diversity selection (e.g. MMR) to the results. Since v1.37.0. |
nit(non-blocking): I think this is the more conventional way of phrasing that
Contributor
There was a problem hiding this comment.
I'd rather be more explicit with requires so the user can't misunderstand
| ), | ||
| limit=3, | ||
| ).objects | ||
| assert [o.uuid for o in balance_0] != [o.uuid for o in balance_1] |
Contributor
There was a problem hiding this comment.
If the goal of this is test is to see that "the client passes diversity_selection parameter to the server correctly", couldn't we just add 2 assertions here? One to check the effect of balance (i.e. order is different) and the other one to check the effect of limit (i.e. len(result) == mmr_limit).
3 distinct test cases just seems to be excessive for this. After all, 95% of the logic is server-side.
Contributor
There was a problem hiding this comment.
Agreed, will try to combine them
Contributor
There was a problem hiding this comment.
Similar to the comment above/below, do we need all 10 test cases for a 2-parameter config?
dirkkul
reviewed
Apr 24, 2026
dirkkul
reviewed
Apr 24, 2026
dirkkul
approved these changes
Apr 24, 2026
bevzzz
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.