Skip to content

get rid of startup warning when not running in warp #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harryalbert merged 2 commits into from
Apr 16, 2026
Merged

get rid of startup warning when not running in warp #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf2b42
get rid of startup warning when not running in warp
harryalbert Apr 16, 2026
0e472da
fix failing test
harryalbert Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions plugins/warp/scripts/legacy/on-session-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,5 @@ if [ "$TERM_PROGRAM" = "WarpTerminal" ]; then
}
EOF
else
# Not running in Warp - suggest installing
cat << 'EOF'
{
"systemMessage": "ℹ️ Warp plugin installed but you're not running in Warp terminal. Install Warp (https://warp.dev) to get native notifications when Claude completes tasks or needs input."
}
EOF
exit 0
fi
7 changes: 0 additions & 7 deletions plugins/warp/tests/test-hooks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,6 @@ assert_eq "legacy Warp shows active message" \
"🔔 Warp plugin active. You'll receive native Warp notifications when tasks complete or input is needed." \
"$SYS_MSG"

# Not Warp (neither env var set)
OUTPUT=$(TERM_PROGRAM=other bash "$HOOK_DIR/on-session-start.sh" < /dev/null 2>/dev/null)
SYS_MSG=$(echo "$OUTPUT" | jq -r '.systemMessage // empty' 2>/dev/null)
assert_eq "non-Warp shows install message" \
"ℹ️ Warp plugin installed but you're not running in Warp terminal. Install Warp (https://warp.dev) to get native notifications when Claude completes tasks or needs input." \
"$SYS_MSG"

echo ""
echo "--- Modern-only hooks exit silently without protocol version ---"

Expand Down
Loading