Add canonical Map arrays and builder - #9108
Draft
AdamGS wants to merge 1 commit into
Draft
Conversation
Merging this PR will improve performance by 20.19%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Building on the logical type and scalar support in #9107, this makes map-typed arrays constructible, canonicalizable, and serializable. A dedicated canonical representation preserves Map semantics instead of treating maps as ordinary lists of structs.
What changes are included in this PR?
vortex.mapcanonical encoding, backed byListView<Struct<key, value>>storage while retaining the Map dtype andkeys_sortedassertion.MapArray, validated construction, entry access, validity delegation, scalar access, serialization, and session registration.MapBuilderand integrates Map values with generic builder and canonicalization paths, including empty, constant, and chunked arrays.What APIs are changed? Are there any user-facing changes?
This adds the public
Map,MapArray,MapArrayExt,MapDataParts, andMapBuilderAPIs.CanonicalandCanonicalViewgain Map variants and corresponding accessors, so exhaustive matches over those enums must handle Map arrays.Map arrays can now be built, canonicalized, inspected, and serialized. Compute paths such as take, filter, masking, compression, and Arrow array transport continue to reject Map arrays at this point in the stack.