feat(cli): embed release version via build.rs instead of CI string replacement#989
Open
Nobody9512 wants to merge 2 commits intovoidzero-dev:mainfrom
Open
feat(cli): embed release version via build.rs instead of CI string replacement#989Nobody9512 wants to merge 2 commits intovoidzero-dev:mainfrom
Nobody9512 wants to merge 2 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.rstovite_global_clithat resolves the version at compile time through a 3-layer fallback:VITE_PLUS_VERSIONenv var →git describe --tags→CARGO_PKG_VERSIONenv!("CARGO_PKG_VERSION")withenv!("VITE_PLUS_VERSION")in the 3 call sites withinvite_global_cliVITE_PLUS_VERSIONenv var and remove the now-unnecessary string replacement forvite_global_cli/Cargo.tomlThis allows distro packagers (Nix, Homebrew, AUR) to build from source with the correct version by setting
VITE_PLUS_VERSION=x.y.z, and local dev builds in a git checkout will automatically pick up the version from git tags instead of showingvp v0.0.0.Closes #976