-
Notifications
You must be signed in to change notification settings - Fork 0
feat: redirect vp-setup.void.app to setup.viteplus.dev #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+50
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { defineMiddleware } from "void"; | ||
|
|
||
| const LEGACY_HOST = "vp-setup.void.app"; | ||
| const CANONICAL_ORIGIN = "https://setup.viteplus.dev"; | ||
|
|
||
| export function buildRedirectTarget(host: string | undefined, requestUrl: string): string | null { | ||
| if (host !== LEGACY_HOST) return null; | ||
| const url = new URL(requestUrl); | ||
| return `${CANONICAL_ORIGIN}${url.pathname}${url.search}`; | ||
| } | ||
|
|
||
| export default defineMiddleware(async (c, next) => { | ||
| const target = buildRedirectTarget(c.req.header("host"), c.req.url); | ||
| if (target) return c.redirect(target, 301); | ||
| await next(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
| import { buildRedirectTarget } from "../middleware/01.redirect-to-custom-domain"; | ||
|
|
||
| describe("buildRedirectTarget", () => { | ||
| it("redirects legacy host root to canonical origin", () => { | ||
| expect(buildRedirectTarget("vp-setup.void.app", "https://vp-setup.void.app/")).toBe( | ||
| "https://setup.viteplus.dev/", | ||
| ); | ||
| }); | ||
|
|
||
| it("preserves path and query string", () => { | ||
| expect( | ||
| buildRedirectTarget("vp-setup.void.app", "https://vp-setup.void.app/?tag=v1.2.3&arch=arm64"), | ||
| ).toBe("https://setup.viteplus.dev/?tag=v1.2.3&arch=arm64"); | ||
| }); | ||
|
|
||
| it("returns null for the custom domain (no redirect)", () => { | ||
| expect(buildRedirectTarget("setup.viteplus.dev", "https://setup.viteplus.dev/")).toBeNull(); | ||
| }); | ||
|
|
||
| it("returns null for localhost during dev", () => { | ||
| expect(buildRedirectTarget("localhost:5173", "http://localhost:5173/")).toBeNull(); | ||
| }); | ||
|
|
||
| it("returns null when host header is missing", () => { | ||
| expect(buildRedirectTarget(undefined, "https://vp-setup.void.app/")).toBeNull(); | ||
| }); | ||
|
|
||
| it("does not match preview/staging subdomains", () => { | ||
| expect( | ||
| buildRedirectTarget("vp-setup-staging.void.app", "https://vp-setup-staging.void.app/"), | ||
| ).toBeNull(); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can the host header ever be null (in a real world scenario)? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand it doesn't, but hono's API does indeed return undefined https://hono.dev/docs/api/request#header 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean technically this is possible with HTTP1 😂
And then the server should reject.