Repository navigation
fix(vite): include same-ID resolutions in module timings - #607
Merged
Merged
Conversation
Record successful resolveId calls even when the returned ID matches the input. Keep declined resolutions in plugin details without assigning them to a final module.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This was referenced Oct 7, 2026
SaKaNa-Y
marked this pull request as ready for review
October 8, 2026 08:13
webfansplz
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please take a moment to read this. Thank you!
I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).
If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.
I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)
I hold myself to this standard for every PR, regardless of its size.
When investigating slow module processing in the Vite module graph, a successful plugin
resolveIdcall can be missing from the module's resolve timings. This happens when the hook returns its input ID, either as a string or as an object with anidfield. Plugin details retain the call, but the module summary excludes it because the ID did not change.Record successful same-ID calls for module aggregation. The existing resolution traversal handles the self-reference, and invalidation removes the recorded timing. Calls that return
undefinedornullremain in plugin details because their records do not identify the final module reliably.Related fixes: #599 includes timings from
transformhooks that return no code. #606 includes timings fromloadhooks that return no code. Each PR targetsmainand can be reviewed and merged independently.Validation on this branch:
pnpm test --run: 52 files passed, 354 tests passed, 2 skipped.pnpm lint,pnpm typecheck, andpnpm buildpassed.