fix: resolve QPoint/QPointF type mismatch when moving vertices fixed #237#238
Open
feyzhen wants to merge 1 commit into
Open
fix: resolve QPoint/QPointF type mismatch when moving vertices fixed #237#238feyzhen wants to merge 1 commit into
feyzhen wants to merge 1 commit into
Conversation
intersection_point() returns a QPoint, which cannot be subtracted from a QPointF in shape vertices, causing a TypeError on drag. Normalize all coordinates to QPointF before arithmetic, fixing the crash when dragging vertices or moving shapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intersection_point() returns a QPoint, which cannot be subtracted from a QPointF in shape vertices, causing a TypeError on drag. Normalize all coordinates to QPointF before arithmetic, fixing the crash when dragging vertices or moving shapes.