Skip to content

Add guard to render chapter slider just once. #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekkraan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add guard to render chapter slider just once. #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2515e51
Run onConnect callback just once. Fixes #1191.
derekkraan Feb 18, 2025
03521ca
Add `IS_IPAD` detection and update iOS controls logic
alexberce Jul 3, 2026
d98ad9c
Merge pull request #1 from alexberce/ipad-fullscreen-captions
derekkraan Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/vidstack/src/core/api/player-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { isNumber } from 'maverick.js/std';

import type { LogLevel } from '../../foundation/logger/log-level';
import type { MediaProviderLoader } from '../../providers/types';
import { canOrientScreen, IS_IPHONE } from '../../utils/support';
import { canOrientScreen, IS_IPAD, IS_IPHONE } from '../../utils/support';
import type { VideoQuality } from '../quality/video-quality';
import { getTimeRangesEnd, getTimeRangesStart, TimeRange } from '../time-ranges';
import type { AudioTrack } from '../tracks/audio/audio-tracks';
Expand Down Expand Up @@ -42,9 +42,9 @@ export const mediaState = new State<MediaState>({
controls: false,
get iOSControls() {
return (
IS_IPHONE &&
this.mediaType === 'video' &&
(!this.playsInline || (!fscreen.fullscreenEnabled && this.fullscreen))
((IS_IPHONE && !this.playsInline) ||
((IS_IPHONE || IS_IPAD) && !fscreen.fullscreenEnabled && this.fullscreen))
);
},
get nativeControls() {
Expand Down
6 changes: 6 additions & 0 deletions packages/vidstack/src/elements/define/sliders/slider-chapters-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@ export class MediaSliderChaptersElement extends Host(HTMLElement, SliderChapters
static tagName = 'media-slider-chapters';

#template: HTMLTemplateElement | null = null;
#connectedRanOnce: Boolean = false;

protected onConnect(): void {
// onConnect can run more than once (eg, Phoenix LiveView after navigation)
if (this.#connectedRanOnce) return;

this.#connectedRanOnce = true;

// Animation frame required as some frameworks append late for some reason.
requestScopedAnimationFrame(() => {
if (!this.connectScope) return;
Expand Down
5 changes: 5 additions & 0 deletions packages/vidstack/src/utils/support.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ import { isFunction, isUndefined, waitTimeout } from 'maverick.js/std';
export const UA = __SERVER__ ? '' : navigator?.userAgent.toLowerCase() || '';
export const IS_IOS = !__SERVER__ && /iphone|ipad|ipod|ios|crios|fxios/i.test(UA);
export const IS_IPHONE = !__SERVER__ && /(iphone|ipod)/gi.test(navigator?.platform || '');

/** iPads report a Mac platform/UA since iPadOS 13. **/
const IS_TOUCH_MAC = navigator?.platform === 'MacIntel' && navigator?.maxTouchPoints > 1;
export const IS_IPAD = !__SERVER__ && (/ipad/.test(UA) || IS_TOUCH_MAC);

export const IS_CHROME = !__SERVER__ && !!window.chrome;
export const IS_IOS_CHROME = !__SERVER__ && /crios/i.test(UA);
export const IS_SAFARI = !__SERVER__ && (!!window.safari || IS_IOS);
Expand Down