Repository navigation
fix(docker): parse indented and lowercase FROM lines - #615
Closed
badrisatyam1-ctrl wants to merge 2 commits into
Closed
badrisatyam1-ctrl wants to merge 2 commits into
badrisatyam1-ctrl wants to merge 2 commits into
Conversation
Contributor
|
Thanks so much for picking up #576, @badrisatyam1-ctrl, and for keeping the change nice and small. It turns out this one is already covered elsewhere, so we won't take it forward separately:
If you'd like another one to work on, there are open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #576
Make Dockerfile FROM matching case-insensitive and tolerant of leading indentation while keeping comments ignored.
Validation: git diff --check passed; Node tests unavailable locally.