Skip to content

fix(docker): parse indented and lowercase FROM lines - #615

Closed
badrisatyam1-ctrl wants to merge 2 commits into
vibgrate:mainfrom
badrisatyam1-ctrl:codex/fix-dockerfile-from-case
Closed

badrisatyam1-ctrl wants to merge 2 commits into
vibgrate:mainfrom
badrisatyam1-ctrl:codex/fix-dockerfile-from-case

Conversation

@badrisatyam1-ctrl

Copy link
Copy Markdown
Contributor

Closes #576

Make Dockerfile FROM matching case-insensitive and tolerant of leading indentation while keeping comments ignored.

Validation: git diff --check passed; Node tests unavailable locally.

@vibgrate-team

Copy link
Copy Markdown
Contributor

Thanks so much for picking up #576, @badrisatyam1-ctrl, and for keeping the change nice and small.

It turns out this one is already covered elsewhere, so we won't take it forward separately:

If you'd like another one to work on, there are open good first issue tickets we'd love help with. Starting each fix on a fresh branch from the latest main will keep older commits out of the diff. Really appreciate you contributing to Vibgrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: lowercase or indented from lines in a Dockerfile are not read as base images

2 participants