Repository navigation
fix: read npm-shrinkwrap.json as an npm lockfile - #611
Open
vibgrate-team wants to merge 1 commit into
Open
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
Projects that only ship npm-shrinkwrap.json fell through to registry range guessing. Reuse the package-lock parser for that filename, and prefer package-lock.json when both files are present. Closes #605 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadNpmLockIndexonly openedpnpm-lock.yaml,package-lock.json, andyarn.lock, so a project that ships onlynpm-shrinkwrap.jsonfell through to registry range guessing. Shrinkwrap is the same JSON as a package-lock, so this change reads it withparsePackageLock/parsePackageLockGraphand with the existing SBOM and pin readers. When both files are present,package-lock.jsonwins and a truncated package-lock still fails instead of falling through.Related issues
Closes #605
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
test/fixtures/npm-shrinkwrap-only/contains onlynpm-shrinkwrap.json. Scan and SBOM resolution use the pinnedleft-pad@1.3.0andonce@1.4.0entries.package-lock.json.DOCS.mdlistsnpm-shrinkwrap.jsonnext to the other npm lockfiles.