feat(selection): auto-open Details panel when lasso/ellipse selection…#647
feat(selection): auto-open Details panel when lasso/ellipse selection…#647vijayvuyyuru wants to merge 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 8f07e71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
vijayvuyyuru
force-pushed
the
auto-open-details-on-multiselect
branch
from
19aa96f to
41b39e3
Compare
… populates When a lasso or ellipse selection transitions from empty to populated, point the existing `selectedEntity` context at the first entity in the selection so the Details panel auto-opens. Track which entity we wrote so a later click on a different entity wins (normal click behavior is preserved). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vijayvuyyuru
force-pushed
the
auto-open-details-on-multiselect
branch
from
41b39e3 to
c7ec234
Compare
|
I think we want to hold off on this for now, this will make it so every user who uses the lasso select will auto-focus on the points they select (which is business logic and opinionated) for context on our approach we will:
if you really need this ASAP we could enable the way you have but could you add a prop to let the auto focus on select be configurable for the component. |
|
@mattmacf98 I don't need this right now, Ill update this PR to make it a prop that can be passed in. |
Auto-selecting the newest entity is opinionated business logic, so it should not fire for every consumer of SelectionTool. Make it opt-in via a new `autoSelectNewEntities` prop that defaults to false.
The prop name is self-explanatory; the changeset documents the behavior.
|
@mattmacf98 Alright, ive updated this to be an opt in prop. |
|
@vijayvuyyuru If you don't need this now I'd recommend holding off - in the near future I'll be refactoring internals so that entity.add(traits.Selected) |
|
If you do need it - please just add a @todo comment saying to remove once a |
Add a TODO noting the prop should be removed once a Selected trait exists, per the longer-term direction in PR #647 review.
|
@micheal-parks Added TODO comment. Thanks for understanding!! |
3 participants
Hey yall this change opens the details panel for a selection upon making it.
I want this change as I am making a tutorial for sanding operators to use the targeting flow. Furthermore, I think this change makes sense as the operator is typically configuring heaviness immediately after making a selection anyway.